Project

General

Profile

Activity

From 11 August 2013 to 09 September 2013

04 September 2013

16:10 Bug #957 (Closed): ReducePyTOFPlot not producing space points
This is closed Rogers, Chris

02 September 2013

17:22 Feature #1338 (Closed): Step needs field information
When in mode where we write each step, it would be useful to write out the field also (for debugging porpoises). Rogers, Chris

30 August 2013

17:02 Feature #1182: Trigger Digitisation
Oh, and I think we only need one of the lines
@ _pileupoffset.push_back(_triggertime);@
and
@ _pileupoffse...
Rogers, Chris
16:57 Feature #1182: Trigger Digitisation
Another bug - in @triggerWithPileup(...)@ it looks like the @do ... while@ loop only piles up adjacent hits. Need to ... Rogers, Chris
15:50 Bug #1331: Memory leak when using SciFiPlane
> deleting the SciFiPlane even if logicalCore and placementCore are preserved still seems to break the reconstruction... Rogers, Chris
14:37 Bug #1331: Memory leak when using SciFiPlane
Update - deleting the SciFiPlane even if logicalCore and placementCore are preserved still seems to break the reconst... Dobbs, Adam

29 August 2013

16:42 Feature #1182: Trigger Digitisation
Found a bug that may have been causing some of the confusion... in the @process@ method... Rogers, Chris
15:15 Feature #1182: Trigger Digitisation
Ah, looks like it moves the digits but does not delete the (now empty) recon event. Rogers, Chris
15:01 Feature #1182: Trigger Digitisation
Issue 1 doesn't sound right at all. Events should get pushed to the data structure, not the MC structure.
Second i...
Bayes, Ryan
14:19 Feature #1182: Trigger Digitisation
I have a working integration test. Two issues arising
# When @triggerevent_pileup@ is True, all events got pushed ...
Rogers, Chris
13:22 Bug #1331: Memory leak when using SciFiPlane
Fix is now in the tracker devel branch (revision 1030), using the method outlined above. I would like some tidying d... Dobbs, Adam

28 August 2013

20:01 Bug #1331: Memory leak when using SciFiPlane
I'll try and expand a bit. Looking at the previous code snippet etc, we want to remove SciFiPlane to prevent a memor... Dobbs, Adam
06:30 Bug #1331: Memory leak when using SciFiPlane
No that's the whole point. ... Rogers, Chris
01:23 Bug #1331: Memory leak when using SciFiPlane
Looks like problem was from MICEDetectorConstruction.cc
if( detector == "SciFiPlane" )
{
SciFiPl...
Heidt, Christopher
18:07 Feature #1182: Trigger Digitisation
Another bug - the MCTriggers are not included in the SpillProcessor. An integration test is needed I think to catch t... Rogers, Chris
16:10 Feature #1182: Trigger Digitisation
Yes I agree. Thanks, Chris. Bayes, Ryan
16:00 Feature #1182: Trigger Digitisation
Something that I added - I made sure that all of the files had the usual MAUS GPL licence in... Rogers, Chris
14:33 Feature #1182: Trigger Digitisation
On python side I note (related to #10) MapPyMCTriggerEventSetup has only 33% line coverage
Rogers, Chris
14:31 Feature #1182: Trigger Digitisation
Attached cpp coverage report. Note that there is no coverage of any of the datastructure stuff. I think this should a... Rogers, Chris
14:27 Feature #1182: Trigger Digitisation
I fixed all of the style errors and checked that tests pass okay at @bash tests/style_tests.bash@. I haven't gone thr... Rogers, Chris
15:38 Feature #1337: Tracker documentation cleanup
Tracker docs should be integrated with the main documentation Rogers, Chris
15:37 Feature #1337 (Closed): Tracker documentation cleanup
Rogers, Chris

22 August 2013

06:36 Feature #1334 (Closed): geant4.9.6 as optional trunk build
Done in r976 Rogers, Chris
06:33 Feature #1334 (Closed): geant4.9.6 as optional trunk build
Want to make geant4.9.6 an optional build in the trunk. Will steal scripts/etc from Bayes's branch to get this to wor... Rogers, Chris
06:31 Feature #1293: Optics/python interface
Ah, sorry about that - it did build on the test server, not sure why it isn't building for you. Thanks for trying any... Rogers, Chris

21 August 2013

20:17 Bug #1331: Memory leak when using SciFiPlane
I'm looking at this now. Heidt, Christopher
19:24 Feature #1293: Optics/python interface
I can't get it to build. It continues to complain about not being able to find numpy even after I install it separate... Lane, Peter
10:39 Feature #1293: Optics/python interface
Thanks. Just be aware, to get it to build you have to run... Rogers, Chris

20 August 2013

22:00 Feature #1293: Optics/python interface
Sure, I'll take a look and post any comments here. Lane, Peter
20:51 Feature #1293: Optics/python interface
Peter, would you like to do a code review? Up to you - it's in branch
bzr+ssh://bazaar.launchpad.net/~chris-rogers...
Rogers, Chris

19 August 2013

12:33 Bug #1331: Memory leak when using SciFiPlane
Thanks for heads up, reassigning to Chris Heidt. Dobbs, Adam

18 August 2013

07:03 Bug #1328: Memory leak in MAUS online recon
I successfully ran through the whole weekends worth of data taking. Observations:
* I checked roughly half way th...
Rogers, Chris

17 August 2013

06:01 Bug #1333 (Closed): MiceModules RepeatModule2 gives weird error on second load
Rogers, Chris
06:00 Bug #1333: MiceModules RepeatModule2 gives weird error on second load
Looks like there was some stuff missing from @MiceModule::deepCopy(...)@
Fixed as part of #1293 (will be committed...
Rogers, Chris

16 August 2013

22:56 Bug #1332: Incorrect transport of time-energy phase space in Optics
I recently finished a mapper that creates residuals between virtual detector hits (MC truth) and "hits" produced by t... Lane, Peter
16:14 Bug #1332: Incorrect transport of time-energy phase space in Optics
Well, think about it carefully. I have to confess, given you are having trouble with time recon I would at least look... Rogers, Chris
15:40 Bug #1332: Incorrect transport of time-energy phase space in Optics
This is likely still a bug. The class that would do this is PolynomialTransferMap in it's Transport() function. I too... Lane, Peter
11:16 Bug #1332 (Rejected): Incorrect transport of time-energy phase space in Optics
Ack, I made a maths error - my mistake... looks okay. Rogers, Chris
09:51 Bug #1332 (Rejected): Incorrect transport of time-energy phase space in Optics
While working on #1293, I found that the time-energy transport in the optics routines is incorrect. The polynomial ma... Rogers, Chris
16:21 Feature #1293: Optics/python interface
Another 12 hours or so of tidying up... styles tests pass, unit tests all pass. Checking integration tests now... Rogers, Chris
15:58 Bug #1328: Memory leak in MAUS online recon
It looks like reconstruction algorithm returns two variables, failed() and successful(). If successful was false and ... Rogers, Chris
15:10 Bug #1328: Memory leak in MAUS online recon
Nailed this down to line 154 of input_transform.py... Rogers, Chris
15:03 Bug #1333 (Closed): MiceModules RepeatModule2 gives weird error on second load
On second loading of attached MiceModule file, all of the VirtualPlanes are placed at 5 m. Looks like there is a bug ... Rogers, Chris

15 August 2013

14:07 Bug #1328: Memory leak in MAUS online recon
Going through @test/integration/test_analyze_online_reconstruction/test_analyze_online_reconstruction.py@ using datas... Rogers, Chris
13:58 Bug #1328: Memory leak in MAUS online recon
I have cleaned up G4 memory usage and this will be merged shortly. However, on second look it appears that the mongod... Rogers, Chris

14 August 2013

16:12 Feature #1293: Optics/python interface
I think I have done all of the memory cleanup from Geant4 I can manage. Remaining leaks are:
Geant4 initialisation...
Rogers, Chris
07:08 Feature #1293: Optics/python interface
Tested everything and checked that it works - mostly by e.g. firing particles and checking that they do what is expec... Rogers, Chris
15:52 Bug #1331 (Open): Memory leak when using SciFiPlane
There is no way to use SciFiPlane to generate a plane without also making a memory leak.
* When I place physiCore ...
Rogers, Chris

12 August 2013

09:33 Feature #1293: Optics/python interface
Another 12 hours or so
I think I figured out the Geant4 stuff. I am bringing @src/legacy/Simulation/MICEDetectorCons...
Rogers, Chris
 

Also available in: Atom