Project

General

Profile

Bug #989

GRID batch script incorrect file name

Added by Rogers, Chris over 9 years ago. Updated over 9 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Testing
Target version:
Start date:
15 May 2012
Due date:
% Done:

100%

Estimated time:
Workflow:
Closed

Description

I think the GRID batch script has an incorrect JSON file name (should be ROOT)

#1

Updated by Lane, Peter over 9 years ago

  • Category set to Testing

I think this is the same issue that I'm running into. The trunk tests are failing with

Traceback (most recent call last):
File "/home/lane/Development/maus/maus/tests/integration/test_utilities/test_execute_against_data/test_execute_against_data.py", line 126, in test_main_success
self.assertTrue(os.path.isfile(file_name), file_name)
AssertionError: 03541_recon.json

In the file tmp/test_batch/downloads.log I see

Traceback (most recent call last):
File "/home/lane/Development/maus/maus/bin/utilities/download_geometry.py", line 80, in <module>
main()
File "/home/lane/Development/maus/maus/bin/utilities/download_geometry.py", line 54, in main
(configuration.geometry_download_run_number, gdml_cache)
File "/home/lane/Development/maus/maus/src/common_py/geometry/GDMLtoCDB.py", line 256, in download_geometry_by_run
downloaded_file = self.geometry_cdb.get_gdml_for_run(long(run_num))
File "/home/lane/Development/maus/maus/third_party/install/lib/python2.7/site-packages/cdb/_geometry.py", line 145, in get_gdml_for_run
parseString(gdml, self._status_handler)
File "/home/lane/Development/maus/maus/third_party/install/lib/python2.7/xml/sax/
_init__.py", line 49, in parseString
parser.parse(inpsrc)
File "/home/lane/Development/maus/maus/third_party/install/lib/python2.7/xml/sax/expatreader.py", line 107, in parse
xmlreader.IncrementalParser.parse(self, source)
File "/home/lane/Development/maus/maus/third_party/install/lib/python2.7/xml/sax/xmlreader.py", line 123, in parse
self.feed(buffer)
File "/home/lane/Development/maus/maus/third_party/install/lib/python2.7/xml/sax/expatreader.py", line 207, in feed
self._parser.Parse(data, isFinal)
File "/home/lane/Development/maus/maus/third_party/install/lib/python2.7/xml/sax/expatreader.py", line 304, in end_element
self._cont_handler.endElement(name)
File "/home/lane/Development/maus/maus/third_party/install/lib/python2.7/site-packages/cdb/_base.py", line 137, in endElement
raise CdbPermanentError(self.message)
cdb._exceptions.CdbPermanentError: Run 3541 not found.

It appears that the GDML for this run cannot be found.

#2

Updated by Rogers, Chris over 9 years ago

  • Assignee set to Rogers, Chris
  • Target version set to Future MAUS release

Actually, the batch script is run in test mode so it should ignore that error. The real error is that the batch script used to make a file called RUN_NUMBER+'_recon.json' or RUN_NUMBER+'_sim.json' - but now the output format is root, I never updated the script. I think I didn't see the bug because the test was being skipped because the data download was failing on my machine (and on the test server)...

anyway, you can ignore the test fail for now and I will fix it when I have time.

#3

Updated by Rogers, Chris over 9 years ago

  • Workflow changed from New Issue to Awaiting Merge

Fixed on my machine ...

#4

Updated by Rogers, Chris over 9 years ago

Gak - pylint!

#5

Updated by Rogers, Chris over 9 years ago

  • Status changed from Open to Closed
  • % Done changed from 0 to 100
  • Workflow changed from Awaiting Merge to Closed

Fixed now and looks to be okay in trunk also

#6

Updated by Rogers, Chris over 9 years ago

  • Target version changed from Future MAUS release to MAUS-v0.2.4

Also available in: Atom PDF