Yeah they are :-)

So I tried running tests. Found few issues:

First the geometry tests weren't being executed by the test script. The scons script only pull code from tests/py_unit/ not tests/py_unit/*/. Need to edit line 634 of $MAUS_ROOT_DIR from

files = glob.glob('tests/py_unit/test_*.py')+glob.glob('tests/style/*.py')

to

files = glob.glob('tests/py_unit/*/test_*.py')+\
        glob.glob('tests/py_unit/test_*.py')+glob.glob('tests/style/*.py')

Second, your run_tests.bash file was corrupted, presumably during a merge. All of this stuff

#<<<<<<< TREE
# To run lcov:-
# (a) Uncomment lines below
# (b) Uncomment some CCFLAGS in SConstruct

#if which lcov >& /dev/null; then 
#    echo Clearing lcov
#    lcov -q -b ${MAUS_ROOT_DIR} --directory src --zerocounters -q
#fi
nosetests -v --with-coverage build
#if which lcov >& /dev/null; then 
#    echo Building lcov output
#    lcov  -q -b ${MAUS_ROOT_DIR} --directory src --capture --output-file maus.info
#    genhtml -o doc/coverage/ maus.info
#fi

=======

and this line

#>>>>>>> MERGE-SOURCE

needs to be deleted. bzr inserts diff output into a file when it finds a conflict. Now I get errors like:

======================================================================
ERROR: Failure: ImportError (dynamic module does not define init function (initlibxml2))
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/cr67/G4MICE/MAUS/maus_littlefield/third_party/install/lib/python2.7/site-packages/nose-1.1.2-py2.7.egg/nose/loader.py", line 390, in loadTestsFromName
    addr.filename, addr.module)
  File "/home/cr67/G4MICE/MAUS/maus_littlefield/third_party/install/lib/python2.7/site-packages/nose-1.1.2-py2.7.egg/nose/importer.py", line 39, in importFromPath
    return self.importFromDir(dir_path, fqname)
  File "/home/cr67/G4MICE/MAUS/maus_littlefield/third_party/install/lib/python2.7/site-packages/nose-1.1.2-py2.7.egg/nose/importer.py", line 86, in importFromDir
    mod = load_module(part_fqname, fh, filename, desc)
  File "/home/cr67/G4MICE/MAUS/maus_littlefield/build/test_gdml_to_maus_module.py", line 8, in <module>
    from geometry.GDMLtoMAUSModule import GDMLtomaus
  File "/home/cr67/G4MICE/MAUS/maus_littlefield/src/common_py/geometry/__init__.py", line 4, in <module>
    from geometry.CADImport import CADImport
  File "/home/cr67/G4MICE/MAUS/maus_littlefield/src/common_py/geometry/CADImport.py", line 6, in <module>
    import libxml2
ImportError: dynamic module does not define init function (initlibxml2)

I think we fixed this but I can't remember how...

I have fixed scons and taken out the corrupted code from run_tests.bash, when I run this I get this error,

test_digit (test_MapCppTOFDigitization.MapCppTOFDigitizationTestCase) ... python2.7: src/map/MapCppTOFDigitization/MapCppTOFDigitization.cc:152: std::string MapCppTOFDigitization::process(std::string): Assertion `mod != __null' failed.
run_tests.bash: line 29: 2716 Aborted nosetests --with-coverage -v build

Not sure what this is or if I'm doing this?

Well done for getting this in - looks really nice!

Comments:

• If you put pylint disable directives at the top of the file, it disables for the entire file. Sometimes you need to do this, but often this is not correct. Better to disable per line by putting a comment at the line end. In particular, you disable the 80 character line limit. Please don't do this!
• Can you put a copyright notice at the top of your files? Something like:
  

  #  This file is part of MAUS: http://micewww.pp.rl.ac.uk:8080/projects/maus
  # 
  #  MAUS is free software: you can redistribute it and/or modify
  #  it under the terms of the GNU General Public License as published by
  #  the Free Software Foundation, either version 3 of the License, or
  #  (at your option) any later version.
  # 
  #  MAUS is distributed in the hope that it will be useful,
  #  but WITHOUT ANY WARRANTY; without even the implied warranty of
  #  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  #  GNU General Public License for more details.
  # 
  #  You should have received a copy of the GNU General Public License
  #  along with MAUS.  If not, see <http://www.gnu.org/licenses/>.
  

I sorted out the latest cdb version as a third party library (together with real suds) and pushed it into bzr+ssh://bazaar.launchpad.net/~chris-rogers/maus/libxml2_test/

Also have a look at the attached test log. The errors where we have

CdbTemporaryError: Unable to contact CDB server at http://cdb.mice.rl.ac.uk/cdb/geometrySuperMouse?wsdl

OSError: [Errno 2] No such file or directory: '/home/matt/maus-littlefield/src/common_py/geometry/testCases/testGeometry/Step_2.gdml'

I have had a look at the errors and I think that the problem is when I call environment variables. To call the MAUS_ROOT_DIR i use

os.environ['MAUS_ROOT_DIR']

All the errors where the file can't be found has this in it but it works on my machine? I think this isn't findind MAUS_ROOT_DIR on jenkins which way do you find this variable?

I'll change it and check it works to see if this is the problem.

FYI, I'm getting different errors on my machine to what you have seen....

For example src/common_py/geometry/testCases/testPacker/FileList.txt

/home/matt/maus-littlefield/src/common_py/geometry/testCases/testGeometry/Step_2.gdml
/home/matt/maus-littlefield/src/common_py/geometry/testCases/testGeometry/Step_0.gdml
/home/matt/maus-littlefield/src/common_py/geometry/testCases/testGeometry/Step_3.gdml
/home/matt/maus-littlefield/src/common_py/geometry/testCases/testGeometry/fastradModel_materials.xml
/home/matt/maus-littlefield/src/common_py/geometry/testCases/testGeometry/fastradModel.gdml
/home/matt/maus-littlefield/src/common_py/geometry/testCases/testGeometry/Step_1.gdml
/home/matt/maus-littlefield/src/common_py/geometry/testCases/testGeometry/Step_4.gdml
/home/matt/maus-littlefield/src/common_py/geometry/testCases/testGeometry/Step_5.gdml

Note I completely removed the old cdb stuff and changed the build scripts to add suds and cdb in 44suds.bash 45cdb.bash

Also

echo $MAUS_ROOT_DIR
/home/cr67/G4MICE/MAUS/maus_littlefield_merge

which is correct. Done using

 source env.sh

OH, I forgot that I have hard coded the Filelist.txt woops I'll change it :-).

I noticed you removed the cdb stuff and I have since built the suds etc scripts on my machine and I no longer get the SuperMouseGeometry connection errors.

All of the stuff in test_ReducePyMatplotlibHistogram.py, well, nothing to do with your code, so maybe something got overwritten. The other stuff is with the cdb tests, which I removed. Probably if you do scons -c; scons these tests should go away. The tests now live in Antony Wilson's code.

Should say - the reason I didn't fix that test is because I really didn't have a clue what the function was doing...

I now have this passing in rogers build e.g. http://test.mice.rl.ac.uk/job/MAUS_rogers/196/

I did quite a bit of messing about - soft coding the URL for test server, moving the executables to bin/utilities, moving the file cache to files/geometry, separating the input directory and output directory for e.g. formatter, few other stuff. I want to finally make an integration test that checks that we can upload sample geometries to the test server, pull them back down again and run simulation against them before I do the merge.

That sounds good. Can I merge it with my local copy so I have the current version? Because I'm going to be doing some stuff with the tracker schema this week and would like my version to be current :-)

what is the branch name?

lp:maus_rogers?

or should I want till the maus release? May be better ...

Branch name is:

bzr+ssh://bazaar.launchpad.net/~chris-rogers/maus/devel/

I think it would be worth at least having a look at the code to see what I've done. You may have some objections, in which case let me know.

Nb: Try to keep your branch clean, there was a whole load of stuff which should not have been committed (temporary files, etc). Makes it quite a pain to merge!

OK Ill be cleaning up my branch :-) so its less painful.

When I try to merge is gives me a warning that I'm doing a criss-cross merge and I read bzr help and it looks scary I think Ill wait til the release because I don't want to mess it up :-)

Okay, well feel free to download my branch at least to have a look...