Support #597
Code review request - MapCppTrackerSpacePoints
0%
Description
For code in src/map/MapCppTrackerSpacePoints/.
Updated by Rogers, Chris over 12 years ago
- Due date set to 05 August 2011
- Category set to common_cpp
- Assignee set to Carlisle, Timothy
- Target version set to Future MAUS release
Assigned to Tim. Note the code review guidelines at:
http://micewww.pp.rl.ac.uk/projects/maus/wiki/Code_review
Get the code with command like:
bzr branch lp:~e-santos10/maus/devel
Updated by Tunnell, Christopher over 12 years ago
Can you put the name of the piece of code to be reviewed in the subject line? Makes it easier to manage.
Updated by Santos, Edward over 12 years ago
- Subject changed from Code review request to Code review request - MapCppTrackerSpacePoints
Updated by Santos, Edward over 12 years ago
For Tim: a few changes are coming for this one. Reduced cpplint errors to almost 0. But comments on readability are welcome.
Updated by Santos, Edward over 12 years ago
Sorry about that, I'm still learning about bazaar. This was added now.
Carlisle, Timothy wrote:
I can't find it in your branch...
Updated by Santos, Edward over 12 years ago
For Rogers and Tunnel: I'm thinking of adding flags with a verbose level in this file. What do you guys think of that? When running over real data, it's nice to have some console output saying what's going on. I hate having to go to the source and add cout's for debugging. Also, I tried to use squeal, but I'm rubbish at it. The following lines do nothing:
if ( 1 ) { //_digits.size() > ClustException) {
Squeak::mout(Squeak::info) << "Event with " << _digits.size() << " clusters. Not running the reconstruction." << std::endl;
}
Help?
Updated by Rogers, Chris over 12 years ago
- Target version changed from Future MAUS release to MAUS-v0.1.0
Updated by Rogers, Chris about 12 years ago
- Due date deleted (
05 August 2011) - Category changed from common_cpp to Tracker
- Assignee changed from Carlisle, Timothy to Dobbs, Adam
Status?
Moved to Dobbs as tracker issue...
Updated by Rogers, Chris about 12 years ago
- Target version changed from MAUS-v0.1.0 to Future MAUS release