Project

General

Profile

Support #597

Code review request - MapCppTrackerSpacePoints

Added by Santos, Edward almost 11 years ago. Updated almost 10 years ago.

Status:
Rejected
Priority:
Normal
Assignee:
Category:
Tracker
Target version:
Start date:
22 July 2011
Due date:
% Done:

0%

Estimated time:
Workflow:

Description

For code in src/map/MapCppTrackerSpacePoints/.

#1

Updated by Rogers, Chris almost 11 years ago

  • Due date set to 05 August 2011
  • Category set to common_cpp
  • Assignee set to Carlisle, Timothy
  • Target version set to Future MAUS release

Assigned to Tim. Note the code review guidelines at:

http://micewww.pp.rl.ac.uk/projects/maus/wiki/Code_review

Get the code with command like:

bzr branch lp:~e-santos10/maus/devel

#2

Updated by Tunnell, Christopher almost 11 years ago

Can you put the name of the piece of code to be reviewed in the subject line? Makes it easier to manage.

#3

Updated by Santos, Edward almost 11 years ago

  • Subject changed from Code review request to Code review request - MapCppTrackerSpacePoints
#4

Updated by Santos, Edward almost 11 years ago

For Tim: a few changes are coming for this one. Reduced cpplint errors to almost 0. But comments on readability are welcome.

#5

Updated by Carlisle, Timothy almost 11 years ago

I can't find it in your branch...

#6

Updated by Santos, Edward almost 11 years ago

Sorry about that, I'm still learning about bazaar. This was added now.

Carlisle, Timothy wrote:

I can't find it in your branch...

#7

Updated by Santos, Edward almost 11 years ago

For Rogers and Tunnel: I'm thinking of adding flags with a verbose level in this file. What do you guys think of that? When running over real data, it's nice to have some console output saying what's going on. I hate having to go to the source and add cout's for debugging. Also, I tried to use squeal, but I'm rubbish at it. The following lines do nothing:

if ( 1 ) { //_digits.size() > ClustException) {
Squeak::mout(Squeak::info) << "Event with " << _digits.size() << " clusters. Not running the reconstruction." << std::endl;
}

Help?

#8

Updated by Rogers, Chris almost 11 years ago

  • Target version changed from Future MAUS release to MAUS-v0.1.0
#9

Updated by Rogers, Chris over 10 years ago

  • Due date deleted (05 August 2011)
  • Category changed from common_cpp to Tracker
  • Assignee changed from Carlisle, Timothy to Dobbs, Adam

Status?

Moved to Dobbs as tracker issue...

#10

Updated by Rogers, Chris over 10 years ago

  • Target version changed from MAUS-v0.1.0 to Future MAUS release
#11

Updated by Rogers, Chris almost 10 years ago

  • Status changed from Open to Rejected

Also available in: Atom PDF