Feature #476
Feature #66: Optics refactor
PhaseSpaceVector clean up
100%
Description
PhaseSpaceVector class - list of items to clean up:
- Concept is a vector in phase space (i.e. x,y,t,px,py,energy) with a few helper functions to remind us that it represents a particle
- Remove references to canonical momentum and vector potential - we may want this feature but not right now (we don't have vector potential in the field maps yet)
- Add comments according to the style guide
- Ensure code complies with cpplint.py
- Add tests - most stuff is reasonably simple getters and setters so just doing set_blah get_blah is a good enough test
Updated by Tunnell, Christopher over 12 years ago
What is the location of this code? tests/integration?
Updated by Rogers, Chris about 12 years ago
- Due date set to 01 January 2012
Peter, can I add this to your task list? I don't think Tim has made any progress... perhaps aim for finished by christmas as with Covariance Matrix?
Updated by Lane, Peter almost 12 years ago
I simplified this into what the name implies, namely just a vector in phase space. It inherits the new Vector class but restricts the size to 6 elements. Accessors and mutators for the different phase space variables are included. I'm working on putting particle properties in a Particle class.
Updated by Lane, Peter almost 12 years ago
- Status changed from Open to Closed
- % Done changed from 0 to 100
Unless this class gets more complicated in the future, I'm considering it tested in TransferMapTest.cc.
Updated by Rogers, Chris almost 12 years ago
- Status changed from Closed to Open
- % Done changed from 100 to 0
- Workflow set to Under Test
Bumped back to in test until test coverage is a bit higher
Updated by Lane, Peter almost 12 years ago
- Status changed from Open to Closed
- % Done changed from 0 to 100
Unit test coverage is above 80%. Closing.
Updated by Rogers, Chris over 11 years ago
- Target version changed from Future MAUS release to MAUS-v0.1.4