Project

General

Profile

Support #466

Tracker code review

Added by Rogers, Chris over 12 years ago. Updated about 12 years ago.

Status:
Rejected
Priority:
Normal
Category:
Tracker
Target version:
Start date:
24 May 2011
Due date:
% Done:

0%

Estimated time:
Workflow:

Description

So I asked on Friday Edward to prepare some code (say a single class) that he thought was good - obeyed style guidelines, tested, commented - so that we could do a little code review (and by reviewing, help Edward to get into the code mode). Thought I would put an issue in to remind us.

Note code review guidelines Code_review

#1

Updated by Tunnell, Christopher over 12 years ago

This ever happen? Good activity for software workshop.

#2

Updated by Tunnell, Christopher over 12 years ago

  • Status changed from Open to Rejected
  • % Done changed from 0 to 100
#3

Updated by Santos, Edward over 12 years ago

If this refers only to MAUS stuff: no. If we can talk about G4MICE here, then yes - there was a big chunk of code committed about 2 weeks ago. It included tests, code clean-up and style check for all tracker recon code up to space-points.

#4

Updated by Tunnell, Christopher over 12 years ago

i think this is a duplicate, so rejected. see other tracker tasks

#5

Updated by Rogers, Chris about 12 years ago

  • Target version changed from Future MAUS release to MAUS-v0.0.4

Also available in: Atom PDF