Project

General

Profile

Bug #414

MapCppTrackerDigitization fails cpplint

Added by Rogers, Chris over 10 years ago. Updated almost 9 years ago.

Status:
Closed
Priority:
Low
Category:
Tracker
Target version:
Start date:
20 April 2011
Due date:
% Done:

100%

Estimated time:
Workflow:

Description

At the moment it is explicitly excluded from the tests i.e. listed in tests/style/test_cpp_style.py::exclude_dirs


Related issues

Blocks MAUS - Feature #508: Cleanup Tracker DigitizationClosedSantos, Edward24 June 201124 June 2011

Actions
#1

Updated by Tunnell, Christopher over 10 years ago

I already spent a fair deal of time on this. It really should be a tracker person that fixes it. I'll send an email next week about this to tracker people to find somebody. It's probably a day of work.

#2

Updated by Rogers, Chris over 10 years ago

  • Assignee changed from Tunnell, Christopher to Aslaninejad, Morteza

Sure, reassigned to Morteza

#3

Updated by Tunnell, Christopher over 10 years ago

The timescale of this work is for v1.0, so weeks.

Morteza: I was telling you about cpplint and pylint. The tracker digitization needs to pass the cpplint I was mentioning.

#4

Updated by Rogers, Chris over 10 years ago

I should say - I reassigned to Morteza as tracker lead developer, he can reassign. I put it in v1.0 as we should at least be keeping on top of new code being cpplint-compliant.

#5

Updated by Tunnell, Christopher over 10 years ago

  • Priority changed from Normal to Low
  • Target version changed from MAUS-v0.0.1 to Future MAUS release

I'm moving this to a future version. Given minimal communication from the tracker group, I say we hold back tracker code from v1.0. If tracker manpower comes, then we can work together to get to spacepoints by v1.0.

#6

Updated by Tunnell, Christopher over 10 years ago

progress? This is a useful project to get used to style guides.

#7

Updated by Tunnell, Christopher over 10 years ago

  • Assignee deleted (Aslaninejad, Morteza)

It's been two months, unassigning this so hopefully somebody from the tracker group picks it up. Students?

#8

Updated by Santos, Edward about 10 years ago

  • Assignee set to Santos, Edward
#9

Updated by Rogers, Chris almost 9 years ago

  • Status changed from Open to Rejected

This is dead?

#10

Updated by Heidt, Christopher almost 9 years ago

I just tested this by removing the reference to MapCppTrackerDigitization from the exclude_dirs list and running the cpp sytle test again. Comes up all tests passed.

#11

Updated by Rogers, Chris almost 9 years ago

  • Status changed from Rejected to Closed
  • % Done changed from 0 to 100
#12

Updated by Rogers, Chris almost 9 years ago

  • Target version changed from Future MAUS release to MAUS-v0.4.1

Also available in: Atom PDF