Project

General

Profile

Bug #323

recpack doesn't compile with some versions of GCC

Added by Tunnell, Christopher about 13 years ago. Updated over 12 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Tunnell, Christopher
Category:
Build System
Target version:
Start date:
04 February 2011
Due date:
% Done:

100%

Estimated time:
Workflow:

Description

#include <stdio.h>

is missing in

util/EAlgebra.cpp

even though it uses sprintf.

#1

Updated by Tunnell, Christopher about 13 years ago

  • Status changed from Open to Closed
  • % Done changed from 0 to 100

Applied in changeset r328.

#2

Updated by Rogers, Chris about 13 years ago

Added a note in g4mice RecPack linked from g4mice DeveloperOverview

#3

Updated by Rogers, Chris about 13 years ago

Nb: The thing I said to Adey about editing RecPack (and any external libraries) - I worry that we struggle to update to a new version. I think especially with RecPack, once we are happy with current versions and have some tests in place we will want to update to a new version - and then we wonder "how did I get that to compile?!" So if there are edits necessary, I think we need to document them somehow.

#4

Updated by Tunnell, Christopher about 13 years ago

No version of recpack fixes this according to what T2K uses (and don't know where to send a patch). We can test against SL and Centos with Jenkins (former Hudson, then Oracle fight). We should write some tests to make sure it still does the same thing within what we care for physics so we can upgrade versions.

I'd just be shocked if we couldn't find something better than recpack. Unless we hire a T2K person, I doubt we'll ever truly understand it.

#5

Updated by Tunnell, Christopher about 13 years ago

The patch I made seems to work for Redhat based distributions.

Testing the rest now.

#6

Updated by Rogers, Chris about 13 years ago

That patch also works for SUSE (I think I mentioned it in some email that I did this).

--

Adey says RecPack is GPL, so one option is to fork it.

For the documentation thing, it's more a "good behaviour" clause - until we really know we are moving off RecPack, I think a few seconds noting this stuff down is time well spent.

#7

Updated by Tunnell, Christopher about 13 years ago

FYI: Malcolm is wondering why we haven't moved to a newer version.

My only answer is that I didn't think we understood everything as well as he did, so couldn't until then.

#8

Updated by Tunnell, Christopher about 13 years ago

Not that a newer version fixed this problem. I'll email the head developer to try to get it fixed since Malcolm gave me the email.

#9

Updated by Rogers, Chris about 13 years ago

New version: we have a code, that we don't know how it works (G4MICE recon), talking to another code that we don't know how it works (RecPack). I think that moving to a new RecPack version would just muddy the waters until we have figured out how/if recpack works... but we should do it sometime.

Anselmo is a busy guy, often doesn't reply to emails.

Nb can Adey see this web page, I think he would be interested.

#10

Updated by Tunnell, Christopher about 13 years ago

It's public to view, it's just that I don't advertise it on the main page (have to click 'projects') and people can't post here yet unless I've added them.

#11

Updated by Santos, Edward over 12 years ago

Works on Kubuntu, provided that autoconf and autogen are installed. Add them to the list of Prerequisites?

Also available in: Atom PDF