Project

General

Profile

Bug #297

replace asserts to errors that

Added by Tunnell, Christopher over 10 years ago. Updated about 10 years ago.

Status:
Rejected
Priority:
Low
Assignee:
Tunnell, Christopher
Category:
Crazy Ideas
Target version:
Start date:
25 January 2011
Due date:
% Done:

0%

Estimated time:
Workflow:

Description

this will ensure smooth running in MLCR


Related issues

Precedes MAUS - Feature #291: digitization cleanup: create value getting functionClosedRogers, Chris26 January 201126 January 2011

Actions
#1

Updated by Tunnell, Christopher over 10 years ago

errors within the datastructure that is. you don't want datataking to suddenly stop.

#2

Updated by Tunnell, Christopher over 10 years ago

  • Assignee deleted (Tunnell, Christopher)

somebody else can take this

#3

Updated by Tunnell, Christopher over 10 years ago

  • Target version set to Future MAUS release
#4

Updated by Rogers, Chris over 10 years ago

Is this still relevant? Should use the error handler stuff I did?

#5

Updated by Rogers, Chris over 10 years ago

  • Status changed from Open to Rejected
  • % Done changed from 0 to 100

Not sure what this even means.

#6

Updated by Tunnell, Christopher over 10 years ago

It means to use your error handler. There is a bunch of code (some I wrote) that uses 'asserts' since we didn't have anything else at the time.

#7

Updated by Rogers, Chris about 10 years ago

  • Target version changed from Future MAUS release to MAUS-v0.0.4
#8

Updated by Tunnell, Christopher about 10 years ago

  • Status changed from Rejected to Open
  • Assignee set to Tunnell, Christopher
  • % Done changed from 100 to 0

Maybe this should be a bug, but look here:

http://micewww.pp.rl.ac.uk/projects/maus/repository/entry/src/map/MapCppTOFDigitization/MapCppTOFDigitization.cc

and grep for 'assert' within the process function. This was code from early days so the error handler doesn't exist. Maybe it should be a bug? Those shouldn't be there so how do we want to handle it? This was a reminder to myself. I'll find all the cases I'm talking about then flag them then try to fix them?

#9

Updated by Tunnell, Christopher about 10 years ago

  • Priority changed from Normal to Low
#10

Updated by Tunnell, Christopher about 10 years ago

  • Tracker changed from Feature to Bug
#11

Updated by Tunnell, Christopher about 10 years ago

  • Status changed from Open to Closed
  • % Done changed from 0 to 100

let's just reject this at code review level

#12

Updated by Tunnell, Christopher about 10 years ago

  • Status changed from Closed to Rejected
  • % Done changed from 100 to 0

Also available in: Atom PDF