Bug #1678
Outputters take data as argument
100%
Related issues
Updated by Rogers, Chris over 8 years ago
Added type conversions for header and footer types to json, python, string to src/common_cpp/Converters
Updated by Rogers, Chris over 8 years ago
Type conversion now available right the way up to the python layer.
Note that the type conversion goes like (just for my sanity, why is it like that?):
src/common_cpp/Converter -> Can be called inside modules, does not require python
src/common_cpp/Utils/PyObjectWrap -> Wraps everything in python, called from PyWrapModule
src/py_cpp/PyConverter -> Called from python API
each layer does slightly different stuff for different use cases...
Updated by Rogers, Chris over 8 years ago
This is done in lp:~chris-rogers/maus/1678
and tests pass locally...
Updated by Rogers, Chris over 8 years ago
- Status changed from Open to Closed
- % Done changed from 0 to 100
Committed to trunk in r839.
Note that I made the API a bit less transparent (and a bit less arcane?) in OutputBase - now user has to define bool _save(PyObject* py_obj)
; in all the other modules, user can do void _process(TEMPLATE* t)
or wahtever. That wasn't possible here because py_obj
can take many types, e.g. JobHeader, RunHeader, Spill, etc. Sorry about that.