Project

General

Profile

Bug #1609

execute_against_data.py should download correct geometry

Added by Rogers, Chris over 6 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
bin(aries)
Target version:
Start date:
20 January 2015
Due date:
% Done:

100%

Estimated time:
Workflow:
New Issue

Description

I pulled this comment from #1601 and made it a new bug as it is related to but different from #1601 issue. Ryan, perhaps you could commit your changes to the trunk and close this issue when it is done? I committed changes for #1601 and closed that issue.

I also updated the execute_MC script based on the changes in Chris' 1601 branch. Similar to the data execution the following datacards should not be set for the same reason.

simulation_geometry_filename
output_root_file_name
verbose_level
will_do_stack_trace
configuration_file
geometry_download_directory

On the other hand, for the MC, the "geometry_download_id" data card should always be set. This number can also set in the command line of the script, but I don't think that is the best way to make that selection.

I also noticed a potential bug in the "execute_against_data" --- the geometry should always download according to the run number but the default is to download by geometry ID. I made the correction, which is an additional argument to the geometry download, in my "geo-devel" branch.

As far as the CDB version goes Janusz might be a better person to consult, but I have tested the branch lp:~janusz-martyniak/mcdb/mice.cdb.client.api-python (which is the only one that has the MCIterationNumber to be used with the simulation) with MAUS and there have been no outstanding problems.

#1

Updated by Bayes, Ryan over 6 years ago

  • Status changed from Open to Closed
  • % Done changed from 0 to 100

The changes have been committed and they are in the latest maus release.

Also available in: Atom PDF