Project

General

Profile

Feature #1601

execute_against_data.py should take Batch iteration number

Added by Rogers, Chris over 7 years ago. Updated over 7 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
bin(aries)
Target version:
-
Start date:
23 December 2014
Due date:
% Done:

100%

Estimated time:
Workflow:
New Issue

Description

  • Take batch iteration number from web
  • Download MC datacards from CDB
  • Download Recon datacards from CDB
  • Hand to MC and recon

Related issues

Related to MAUS - Bug #1471: CDB third party invalid urlOpenMartyniak, Janusz21 May 2014

Actions
#1

Updated by Rogers, Chris over 7 years ago

  • Tracker changed from Bug to Feature
#2

Updated by Rogers, Chris over 7 years ago

Changes committed to lp:~chris-rogers/maus/1601

It is in test e.g. http://test.mice.rl.ac.uk/job/MAUS_rogers/549/console but test will fail until there is a cdb release that I can test against.

#3

Updated by Rogers, Chris over 7 years ago

Nb: note that it is not recommended to set any of the following datacards (they are coded into the batch script):

            simulation_geometry_filename
            output_root_file_name
            verbose_level
            will_do_stack_trace
            configuration_file
            reconstruction_geometry_filename
            geometry_download_run_number
            geometry_download_directory
#4

Updated by Rogers, Chris over 7 years ago

Happy new year! Bump - I am waiting for new cdb version to close the issue.

#5

Updated by Dobbs, Adam over 7 years ago

Whose responsibility is the CDB? Janusz, Ryan? I will make a release when the update is ready...

#6

Updated by Bayes, Ryan over 7 years ago

I also updated the execute_MC script based on the changes in Chris' 1601 branch. Similar to the data execution the following datacards should not be set for the same reason.

            simulation_geometry_filename
            output_root_file_name
            verbose_level
            will_do_stack_trace
            configuration_file
            geometry_download_directory

On the other hand, for the MC, the "geometry_download_id" data card should always be set. This number can also set in the command line of the script, but I don't think that is the best way to make that selection.

I also noticed a potential bug in the "execute_against_data" --- the geometry should always download according to the run number but the default is to download by geometry ID. I made the correction, which is an additional argument to the geometry download, in my "geo-devel" branch.

As far as the CDB version goes Janusz might be a better person to consult, but I have tested the branch lp:~janusz-martyniak/mcdb/mice.cdb.client.api-python (which is the only one that has the MCIterationNumber to be used with the simulation) with MAUS and there have been no outstanding problems.

#7

Updated by Rogers, Chris over 7 years ago

As far as the CDB version goes Janusz might be a better person to consult, but I have tested the branch lp:~janusz-martyniak/mcdb/mice.cdb.client.api-python
(which is the only one that has the MCIterationNumber to be used with the simulation) with MAUS and there have been no outstanding problems.

Just so you know, I asked Janusz to make a new cdb python client api release; when that is ready I was planning to update the appropraite third_party/bash script.

#8

Updated by Rajaram, Durga over 7 years ago

I updated CDB third party in the MAUS trunk to use the new version 1.1.2 published by Janusz

Adam, would you make a release once Chris's 1601 branch is tested and merged?

#9

Updated by Rajaram, Durga over 7 years ago

FYI: I have started the MAUS_per_commit_third_party job on the test server to rebuild the $(NODE_THIRD_PARTY) commons on the test server with the new CDB version.
The trunk jobs need to follow

#10

Updated by Rogers, Chris over 7 years ago

Test failed on a real error (in bin/utilities/test_execute_against_data.py). I will have a dig...

#11

Updated by Rogers, Chris over 7 years ago

There was an error because the test was not handed a valid batch iteration number - this is the old test, I guess I forgot to update it. I fixed that and it appears to be working... I put it back on the test server.

#12

Updated by Rajaram, Durga over 7 years ago

Can this go into the trunk now?

#13

Updated by Rogers, Chris over 7 years ago

  • Status changed from Open to Closed
  • % Done changed from 0 to 100

Also available in: Atom PDF