Project

General

Profile

Bug #1147

Configuration management in bin/utilities/get_beamline_info.py

Added by Rogers, Chris almost 9 years ago. Updated almost 9 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Littlefield, Matthew
Category:
bin(aries)
Target version:
Start date:
04 October 2012
Due date:
% Done:

100%

Estimated time:
Workflow:
New Issue

Description

Matt, can you do the configuration management in the same way as the other utilities - or document how it is done (e.g. from argparse)? You absolutely never should tell users to edit the ConfigurationDefaults file - these are defaults - not user input. If you want user to change configuration, please use Configuration.getConfigJSON(...) (which gives you functionality to parse command line arguments for example.

Also, is there any reason why the defaults in

#get beamline information
get_beamline_by = "run_number" #This sets the method which you would like to query the beamline database. Options are 'run_number' and 'dates'
get_beamline_run_number = "" 
get_beamline_start_time = "" 
get_beamline_stop_time = "" 

don't work? Final complaint - could you document these configuration parameters somewhere?

Cheers

#1

Updated by Littlefield, Matthew almost 9 years ago

Sure, I think I was a little lazy when I wrote this my apologies. I'll change the defaults so that they work when the utility is called and I'll take a look at the way arguments are called for the other files and implement it :-).

#2

Updated by Rogers, Chris almost 9 years ago

I have a thing - lazy in source code happens, but is bad. Lazy in user interface I am rather less tolerant on user interface/exes - it gives a really bad impression if the executable just blows up.

#3

Updated by Littlefield, Matthew almost 9 years ago

That's fair I'll get it sorted out :-)

#4

Updated by Littlefield, Matthew almost 9 years ago

  • Status changed from Open to Closed
  • % Done changed from 0 to 100
#5

Updated by Rogers, Chris almost 9 years ago

  • Target version changed from Future MAUS release to MAUS-v0.4.0

Also available in: Atom PDF