Project

General

Profile

Bug #1145

bin/utilities/get_beamline_info.py does not work

Added by Rogers, Chris almost 9 years ago. Updated almost 9 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Littlefield, Matthew
Category:
bin(aries)
Target version:
Start date:
03 October 2012
Due date:
% Done:

100%

Estimated time:
Workflow:
New Issue

Description

I do

>$ python bin/utilities/get_beamline_info.py 

and get
Server status is OK
Traceback (most recent call last):
  File "bin/utilities/get_beamline_info.py", line 65, in <module>
    main()
  File "bin/utilities/get_beamline_info.py", line 37, in main
    id_dict = server.get_beamline_for_run(run)
  File "/home/cr67/MAUS/maus_merge/third_party/install/lib/python2.7/site-packages/cdb/_beamline.py", line 153, in get_beamline_for_run
    self.get_beamline_for_run_xml(run_number))
  File "/home/cr67/MAUS/maus_merge/third_party/install/lib/python2.7/site-packages/cdb/_beamline.py", line 335, in _parse_beam_line_xml
    parseString(xml, self._beamline_handler)
  File "/home/cr67/MAUS/maus_merge/third_party/install/lib/python2.7/xml/sax/__init__.py", line 49, in parseString
    parser.parse(inpsrc)
  File "/home/cr67/MAUS/maus_merge/third_party/install/lib/python2.7/xml/sax/expatreader.py", line 107, in parse
    xmlreader.IncrementalParser.parse(self, source)
  File "/home/cr67/MAUS/maus_merge/third_party/install/lib/python2.7/xml/sax/xmlreader.py", line 123, in parse
    self.feed(buffer)
  File "/home/cr67/MAUS/maus_merge/third_party/install/lib/python2.7/xml/sax/expatreader.py", line 207, in feed
    self._parser.Parse(data, isFinal)
  File "/home/cr67/MAUS/maus_merge/third_party/install/lib/python2.7/xml/sax/expatreader.py", line 304, in end_element
    self._cont_handler.endElement(name)
  File "/home/cr67/MAUS/maus_merge/third_party/install/lib/python2.7/site-packages/cdb/_beamline.py", line 418, in endElement
    raise CdbPermanentError(self._message)
cdb._exceptions.CdbPermanentError: Value: is not a valid int

Also, I didn't see a test for this code. Should be in tests/integration/test_utilities.

#1

Updated by Littlefield, Matthew almost 9 years ago

the tests are in /tests/integration/test_utilities/test_geometry and the error is from not specifying the ConfigurationDefaults. I shall push some new code to the merge branch which handles this in a nicer way.

Are you planning to make a new release soon? If so, I may push some new code to extend the geometry stuff to include the Technical_Drawing_number information which Antony added. :-)

#2

Updated by Rogers, Chris almost 9 years ago

Great that there are tests.

I already made the development freeze and new release will go out later today. I will try to get another one in before the CM, any changes will have to go there...

#3

Updated by Littlefield, Matthew almost 9 years ago

OK no problem, Should I push the stuff which handles the errors above? Or what til the release has been made?

#4

Updated by Rogers, Chris almost 9 years ago

Please go ahead and push. I figured out a release procedure that doesnt hog the trunk...

#5

Updated by Littlefield, Matthew almost 9 years ago

OK that's in now :-)

#6

Updated by Littlefield, Matthew almost 9 years ago

  • Status changed from Open to Closed
  • % Done changed from 0 to 100
#7

Updated by Rogers, Chris almost 9 years ago

  • Target version changed from Future MAUS release to MAUS-v0.4.0

Also available in: Atom PDF