Feature #1045
KL merge
Start date:
10 July 2012
Due date:
% Done:
0%
Estimated time:
Workflow:
Awaiting Merge
Description
Mariyan requested a merge.
Files
Updated by Rogers, Chris over 11 years ago
- File cpplint.out cpplint.out added
Following merge - tests all pass on my machine except the C++ style test. Can you have a look (see attached cpplint.out)
cheers
Updated by Bogomilov, Mariyan over 11 years ago
- Status changed from Open to Closed
- % Done changed from 0 to 100
Updated by Rogers, Chris over 11 years ago
- Status changed from Closed to Open
- Assignee changed from Bogomilov, Mariyan to Rogers, Chris
- % Done changed from 100 to 0
Updated by Rogers, Chris over 11 years ago
- File KLChannelMap-coverage.png KLChannelMap-coverage.png added
- File KL-data-structure-coverage.png KL-data-structure-coverage.png added
- File MapcppKLCellHits-coverage.png MapcppKLCellHits-coverage.png added
- File MapCppKLDigits-coverage.png MapCppKLDigits-coverage.png added
- Assignee changed from Rogers, Chris to Bogomilov, Mariyan
Test coverage is in general quite poor. I attached some screenshots of the unit test coverage for your code (generated using lcov). It looks like you never wrote any unit tests, perhaps there is some problem and the test script didn't find them? You need to please fix this before I can do the merge, or give me a ring if you have any questions. More information on unit tests is available at Unit_tests. Also I would be grateful if you could supply a page of latex on the KL reconstruction routines in, say, doc/doc_src/detectors/kl.tex
.