Project

General

Profile

Feature #1045

KL merge

Added by Rogers, Chris about 9 years ago. Updated about 9 years ago.

Status:
Open
Priority:
Normal
Category:
KL
Target version:
Start date:
10 July 2012
Due date:
% Done:

0%

Estimated time:
Workflow:
Awaiting Merge

Description

Mariyan requested a merge.


Files

cpplint.out (9.9 KB) cpplint.out Rogers, Chris, 10 July 2012 12:07
KLChannelMap-coverage.png (230 KB) KLChannelMap-coverage.png Rogers, Chris, 16 July 2012 12:03
KL-data-structure-coverage.png (259 KB) KL-data-structure-coverage.png Rogers, Chris, 16 July 2012 12:03
MapcppKLCellHits-coverage.png (98.6 KB) MapcppKLCellHits-coverage.png Rogers, Chris, 16 July 2012 12:03
MapCppKLDigits-coverage.png (99.1 KB) MapCppKLDigits-coverage.png Rogers, Chris, 16 July 2012 12:03
#1

Updated by Rogers, Chris about 9 years ago

Following merge - tests all pass on my machine except the C++ style test. Can you have a look (see attached cpplint.out)

cheers

#2

Updated by Bogomilov, Mariyan about 9 years ago

  • Status changed from Open to Closed
  • % Done changed from 0 to 100
#3

Updated by Rogers, Chris about 9 years ago

  • Status changed from Closed to Open
  • Assignee changed from Bogomilov, Mariyan to Rogers, Chris
  • % Done changed from 100 to 0
#4

Updated by Rogers, Chris about 9 years ago

Test coverage is in general quite poor. I attached some screenshots of the unit test coverage for your code (generated using lcov). It looks like you never wrote any unit tests, perhaps there is some problem and the test script didn't find them? You need to please fix this before I can do the merge, or give me a ring if you have any questions. More information on unit tests is available at Unit_tests. Also I would be grateful if you could supply a page of latex on the KL reconstruction routines in, say, doc/doc_src/detectors/kl.tex.

Also available in: Atom PDF